Re: [PATCH] iommu: arm-smmu: correct sid to mask

[Will Deacon]

On Fri, Apr 21, 2017 at 05:03:36PM +0800, Peng Fan wrote:
> From code "SMR mask 0x%x out of range for SMMU",
> so, we need to use mask, not sid.
> 
> Signed-off-by: Peng Fan <peng.fan@xxxxxxx>
> Cc: Will Deacon <will.deacon@xxxxxxx>
> Cc: Robin Murphy <robin.murphy@xxxxxxx>
> ---
>  drivers/iommu/arm-smmu.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iommu/arm-smmu.c b/drivers/iommu/arm-smmu.c
> index b493c99..5a06de2 100644
> --- a/drivers/iommu/arm-smmu.c
> +++ b/drivers/iommu/arm-smmu.c
> @@ -1467,7 +1467,7 @@ static int arm_smmu_add_device(struct device *dev)
>  		}
>  		if (mask & ~smmu->smr_mask_mask) {
>  			dev_err(dev, "SMR mask 0x%x out of range for SMMU (0x%x)\n",
> -				sid, smmu->smr_mask_mask);
> +				mask, smmu->smr_mask_mask);
>  			goto out_free;

Looks like a copy-paste error to me:

Acked-by: Will Deacon <will.deacon@xxxxxxx>

Joerg: do you mind picking this one up, please?

Thanks,

Will