Re: [PATCH] platform/x86: asus-wmi: fix cpufv sysfs file permission

From: JÃrÃmy Lefaure
Date: Mon Apr 24 2017 - 11:31:43 EST


On Mon, 24 Apr 2017 12:14:14 +0300
Andy Shevchenko <andy.shevchenko@xxxxxxxxx> wrote:

> On Sat, Apr 22, 2017 at 5:19 AM, JÃrÃmy Lefaure
> <jeremy.lefaure@xxxxxxxxxxxx> wrote:
> > The cpufv sysfs file is defined as readable by anyone even if the
> > attribute does not have a show function. The result of every read is an
> > IO error. This file should be write only.
>
> Per se patch looks good to me, though would be better to add show()
> hook as well?
>
It depends if we want to keep it write-only as it is documented in
Documentation/ABI/testing/sysfs-platform-asus-wmi.

If we want to have this file read/write, I can send a v2 of this patch.