Re: [PATCH v1 2/2] gpio: gpio-wcove: fix irq pending status bit width

From: Andy Shevchenko
Date: Mon Apr 24 2017 - 10:27:59 EST


On Mon, 2017-04-24 at 15:15 +0200, Linus Walleij wrote:
> On Fri, Apr 14, 2017 at 7:29 PM,
> <sathyanarayanan.kuppuswamy@xxxxxxxxxxxxxxx> wrote:
>
> > From: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@xxxxxxx
> > ntel.com>
> >
> > Whiskey cove PMIC has three GPIO banks with total number of 13 GPIO
> > pins. But when checking for the pending status, for_each_set_bit()
> > uses
> > bit width of 7 and hence it only checks the status for first 7 GPIO
> > pins
> > missing to check/clear the status of rest of the GPIO pins. This
> > patch
> > fixes this issue.
> >
> > Signed-off-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswam
> > y@xxxxxxxxxxxxxxx>
>
> Looks reasonable so patch applied.
>
> Just looping in Mika & Andy so they have an idea about what's going
> on.

This is fine by me, thanks!


--
Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Intel Finland Oy