Re: [PATCH v3 15/18] arm64: arch_timer: Enable CNTVCT_EL0 trap if workaround is enabled

From: Marc Zyngier
Date: Mon Apr 24 2017 - 04:40:17 EST


On 24/04/17 09:25, Lixiaoping (Timmy) wrote:
> Hi Marc,
>
> Sorry about previous email's confidential info. Please forget it.
>
> +#define ESR_ELx_SYS64_ISS_SYS_CNTFRQ (ESR_ELx_SYS64_ISS_SYS_VAL(3, 3, 14, 0, 0) | \
> + ESR_ELx_SYS64_ISS_DIR_READ)
>
> I think (3, 3, 14, 0, 0) should be (3, 3, 0, 14, 0)?

Thanks for spotting this. I assumed that the sys_reg() and
SR_ELx_SYS64_ISS_SYS_VAL() macros took their arguments in the same
order. That would have been too easy... ;-)

Amended patch below, please let me know if it works for you.

Thanks,

M.