Re: [PATCH 06/38] Annotate hardware config module parameters in drivers/clocksource/

From: Thomas Gleixner
Date: Sat Apr 15 2017 - 01:50:09 EST


On Fri, 14 Apr 2017, David Howells wrote:
> Thomas Gleixner <tglx@xxxxxxxxxxxxx> wrote:
>
> > > -module_param_named(irq, timer_irq, int, 0644);
> > > +module_param_hw_named(irq, timer_irq, int, irq, 0644);
> > > MODULE_PARM_DESC(irq, "Which IRQ to use for the clock source MFGPT ticks.");
> >
> > I'm not sure about this. AFAIR the parameter is required to work on
> > anything else than some arbitrary hardware which has it mapped to 0.
>
> Should it then be set through in-kernel platform initialisation since the
> AMD Geode is an embedded chip?

I think so.

> Btw, is it possible to use IRQ grants to prevent a device that has limited IRQ
> options from being drivable?

What do you mean with 'IRQ grants' ?

Thanks

tglx