Re: [PATCH] remove return statement

From: Joe Perches
Date: Sat Apr 15 2017 - 01:18:03 EST


On Sat, 2017-04-15 at 10:35 +0530, surenderpolsani wrote:
> staging : rtl8188e : remove return in void function

Your patch subject isn't correct.

It should be something like:

Subject: [PATCH] staging: rtl8188e: Remove void function return

> kernel coding style doesn't allow the return statement
> in void function.
[]
> diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_dm.c b/drivers/staging/rtl8188eu/hal/rtl8188e_dm.c
[]
> @@ -165,7 +165,6 @@ void rtw_hal_dm_watchdog(struct adapter *Adapter)
> skip_dm:
> /* Check GPIO to determine current RF on/off and Pbc status. */
> /* Check Hardware Radio ON/OFF or not */
> - return;

And the comments?
Are those supposed to be reminders of code to write?