Re: [PATCH 2/6] KVM: VMX: remove bogus check for invalid EPT violation

From: David Hildenbrand
Date: Wed Apr 12 2017 - 16:00:41 EST


On 30.03.2017 11:55, Paolo Bonzini wrote:
> handle_ept_violation is checking for "guest-linear-address invalid" +
> "not a paging-structure walk". However, _all_ EPT violations without
> a valid guest linear address are paging structure walks, because those
> EPT violations happen when loading the guest PDPTEs.
>
> Therefore, the check can never be true, and even if it were, KVM doesn't
> care about the guest linear address; it only uses the guest *physical*
> address VMCS field. So, remove the check altogether.
>
> Signed-off-by: Paolo Bonzini <pbonzini@xxxxxxxxxx>

Reviewed-by: David Hildenbrand <david@xxxxxxxxxx>

--

Thanks,

David