Re: iov_iter_pipe warning.

From: Dave Jones
Date: Tue Apr 11 2017 - 19:46:05 EST


On Wed, Apr 12, 2017 at 12:28:42AM +0100, Al Viro wrote:
> On Tue, Apr 11, 2017 at 06:25:02PM -0400, Dave Jones wrote:
>
> > ffffffff812b3130 T generic_splice_sendpage
> >
> > This one spat out all by itself.
>
> No need to print ->f_op for that one - can be only socket_file_ops. Now,
> the address family of that socket would be interesting...
>
> How about adding to that printk (under if (WARN_ON()) something like
> file = sd->u.file;
> if (file->f_op->splice_write == generic_splice_sendpage) {
> struct socket *sock = file->private_data;
> printk(KERN_ERR "socket [%d, %p]\n", sock->type, sock->ops);
> }
> printk(KERN_ERR "in->f_op = %p\n", in->f_op);

Ugh, this explodes with a million errors when I try to compile it.
It misses socket definition, and include <linux/net.h> causes another
cascade of errors about linkage.h and nonsense.

Send me a diff, I'll check in later.

Dave