Re: [PATCH v2] checkpatch: special audit for revert commit line

From: Joe Perches
Date: Tue Apr 11 2017 - 15:23:39 EST


On Tue, 2017-04-11 at 12:15 -0700, Wei Wang wrote:
> From: Wei Wang <wvw@xxxxxxxxxx>
>
> Currently checkpatch.pl does not recognize git's default
> commit revert message and will complain about the hash format.
> Add special audit for revert commit message line to fix it.
>
> Signed-off-by: Wei Wang <wvw@xxxxxxxxxx>

Acked-by: Joe Perches <joe@xxxxxxxxxxx>

> ---
> scripts/checkpatch.pl | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index baa3c7be04ad..9570db236ba3 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -2539,6 +2539,7 @@ sub process {
> # Check for git id commit length and improperly formed commit descriptions
> if ($in_commit_log && !$commit_log_possible_stack_dump &&
> $line !~ /^\s*(?:Link|Patchwork|http|https|BugLink):/i &&
> + $line !~ /^This reverts commit [0-9a-f]{7,40}/ &&
> ($line =~ /\bcommit\s+[0-9a-f]{5,}\b/i ||
> ($line =~ /(?:\s|^)[0-9a-f]{12,40}(?:[\s"'\(\[]|$)/i &&
> $line !~ /[\<\[][0-9a-f]{12,40}[\>\]]/i &&