Re: [PATCH 1/2] firmware: Google VPD: import lib_vpd source files

[Thierry Escande]

On 11/04/2017 16:11, Greg Kroah-Hartman wrote:
> On Tue, Apr 11, 2017 at 04:10:12PM +0200, Greg Kroah-Hartman wrote:
> > On Tue, Apr 11, 2017 at 11:14:30AM +0200, Thierry Escande wrote:
...
> > > +	}
> > > +
> > > +	return VPD_OK;
> > > +}
> > > +EXPORT_SYMBOL(decode_vpd_string);
> >
> > Normally put the prefix for the driver you are exporting from:
> > 	vpd_string_decode()?
> >
> > And EXPORT_SYMBOL_GPL() perhaps?
>
> Wait, why is this even exported?  You build this into the module that
> needs it...

Right. Will fix that as well.

Regards,
 Thierry