Re: [PATCH v9 3/3] printk: fix double printing with earlycon

From: Sergey Senozhatsky
Date: Mon Apr 10 2017 - 21:54:30 EST


On (04/10/17 21:00), Aleksey Makarov wrote:
> On 04/10/2017 05:22 PM, Petr Mladek wrote:
> > On Wed 2017-04-05 23:20:00, Aleksey Makarov wrote:
[..]
> > > To fix that, introduce an invariant "The last non-braille console
> > > is always the preferred one" on the entries of the console_cmdline
> > > array. Then traverse it in reverse order to be sure that if
> > > the console is preferred then it will be the first matching entry.
> > > Introduce variable console_cmdline_cnt that keeps the number
> > > of elements of the console_cmdline array (Petr Mladek). It helps
> > > to get rid of the loop that searches for the end of this array.
> > >
> > > Reported-by: Sudeep Holla <sudeep.holla@xxxxxxx>
> > > Signed-off-by: Aleksey Makarov <aleksey.makarov@xxxxxxxxxx>
> >
> > This version looks fine to me. Just a small nitpick below.
> > Anyway:
> >
> > Reviewed-by: Petr Mladek <pmladek@xxxxxxxx>
>
> Thank you for review. Can you (or anybody else) ACK it?
> I am going to resend the whole series without those empty lines.
> May I add your Acked-by:?

Acked-by: Sergey Senozhatsky <sergey.senozhatsky@xxxxxxxxx>

feel free to resend. I know some setups that have repeating (double)
lines on the serial console, I'll ask people to test the patches.

-ss