Re: [greybus-dev] [PATCH] staging: greybus: compress return logic

From: Viresh Kumar
Date: Mon Apr 10 2017 - 00:45:33 EST


On 25-03-17, 10:50, Arushi Singhal wrote:
> Simplify function returns by merging assignment and return.
>
> Signed-off-by: Arushi Singhal <arushisinghal19971997@xxxxxxxxx>
> ---
> drivers/staging/greybus/loopback.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/staging/greybus/loopback.c b/drivers/staging/greybus/loopback.c
> index aaf29a5fac83..08e255884206 100644
> --- a/drivers/staging/greybus/loopback.c
> +++ b/drivers/staging/greybus/loopback.c
> @@ -365,11 +365,8 @@ static void gb_loopback_calculate_stats(struct gb_loopback *gb, bool error);
>
> static u32 gb_loopback_nsec_to_usec_latency(u64 elapsed_nsecs)
> {
> - u32 lat;
> -
> do_div(elapsed_nsecs, NSEC_PER_USEC);
> - lat = elapsed_nsecs;
> - return lat;
> + return elapsed_nsecs;
> }
>
> static u64 __gb_loopback_calc_latency(u64 t1, u64 t2)

Acked-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx>

--
viresh