Re: [PATCH v2 00/11] fujitsu-laptop: backlight cleanup

From: Darren Hart
Date: Wed Apr 05 2017 - 23:11:48 EST


On Thu, Apr 06, 2017 at 10:15:14AM +0930, Jonathan Woithe wrote:
> Hi Michael
>
> On Wed, Apr 05, 2017 at 09:55:34PM +0200, Micha?? K??pie?? wrote:
> > > On Wed, Apr 05, 2017 at 08:48:59AM +0200, Micha?? K??pie?? wrote:
> > > > This series introduces further changes to the way LCD backlight is
> > > > handled by fujitsu-laptop. These changes include fixing a bug in code
> > > > responsible for generating brightness-related input events, cleaning up
> > > > handling of module parameters, reducing code duplication, removing
> > > > superfluous debug messages and other fixes.
> > > >
> > > > This series was tested on a Lifebook S7020 and a Lifebook E744.
> > > >
> > > > This series is based on the testing branch as it requires earlier patch
> > > > series I submitted in order to apply cleanly.
> > > >
> > > > Changes from v1:
> > > >
> > > > - Update debug message logged by set_lcd_level() to reflect code flow
> > > > changes introduced by patch 04/11.
> > >
> > > Queued to testing, thanks!
> >
> > Jonathan, I would still love to hear your opinion on this series. Take
> > your time, though, I do not see any reason to rush things. I will only
> > send the next series once you ack this one.
>
> Sure, no problem. As mentioned earlier, this week has been busy. I am
> hoping I might find the time to complete my review this evening. If not, it
> will be some time over the weekend.

Eeek, I jumped the gun on that. I've moved this from testing to fujitsu, and
it'll wait there until Jonathan gets a chance to review. Apologies Jonathan.

--
Darren Hart
VMware Open Source Technology Center