RE: [PATCH 2/2] x86/mce/AMD: Carve out SMCA bank configuration

From: Ghannam, Yazen
Date: Tue Apr 04 2017 - 10:37:48 EST


> -----Original Message-----
> From: Borislav Petkov [mailto:bp@xxxxxxxxx]
> Sent: Tuesday, April 04, 2017 9:46 AM
> To: Ghannam, Yazen <Yazen.Ghannam@xxxxxxx>
> Cc: linux-edac@xxxxxxxxxxxxxxx; Tony Luck <tony.luck@xxxxxxxxx>;
> x86@xxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH 2/2] x86/mce/AMD: Carve out SMCA bank configuration
>
> On Tue, Apr 04, 2017 at 01:34:42PM +0000, Ghannam, Yazen wrote:
> > I'd like to keep the functions separate since they're logically
> > independent. I can define something like smca_configure() as a wrapper
> > function that can contain current and future SMCA related functions. Is this
> okay?
>
> Are you planning to call the one and not the other in some path?

No, not at the moment. This patch is just to help with readability.

Thanks,
Yazen