Re: [PATCH] mm/mmap: Replace SHM_HUGE_MASK with MAP_HUGE_MASK inside mmap_pgoff

From: Matthew Wilcox
Date: Tue Apr 04 2017 - 08:02:49 EST


On Tue, Apr 04, 2017 at 10:26:35AM +0530, Anshuman Khandual wrote:
> The commit 091d0d55b286 ("shm: fix null pointer deref when userspace
> specifies invalid hugepage size") had replaced MAP_HUGE_MASK with
> SHM_HUGE_MASK. Though both of them contain the same numeric value of
> 0x3f, MAP_HUGE_MASK flag sounds more appropriate than the other one
> in the context. Hence change it back.
>
> Acked-by: Balbir Singh <bsingharora@xxxxxxxxx>
> Acked-by: Michal Hocko <mhocko@xxxxxxxx>
> Signed-off-by: Anshuman Khandual <khandual@xxxxxxxxxxxxxxxxxx>

Reviewed-by: Matthew Wilcox <mawilcox@xxxxxxxxxxxxx>

We had a more extensive version of this last week ...

https://lkml.org/lkml/2017/3/28/1005

I'm fine with this minor fix going in by itself.