Re: [PATCH 2/4] mfd: cpcap: Use handle_reread flag for interrupts
From: Tony Lindgren
Date: Mon Apr 03 2017 - 23:17:56 EST
* Lee Jones <lee.jones@xxxxxxxxxx> [170403 07:34]:
> On Mon, 03 Apr 2017, Tony Lindgren wrote:
>
> > Hi,
> >
> > * Lee Jones <lee.jones@xxxxxxxxxx> [170403 03:23]:
> > > On Wed, 22 Mar 2017, Tony Lindgren wrote:
> > >
> > > > On CPCAP we need to keep reading interrupts until there are no
> > > > more interrupts. Otherwise the PMIC interrupt to the SoC will at
> > > > some point stop toggling. This seems to happen because new CPCAP
> > > > device interrupts show up while we're handling.
> > > >
> > > > Cc: Charles Keepax <ckeepax@xxxxxxxxxxxxxxxxxxxxxxxxxxx>
> > > > Cc: Lee Jones <lee.jones@xxxxxxxxxx>
> > > > Cc: Marcel Partap <mpartap@xxxxxxx>
> > > > Cc: Michael Scott <michael.scott@xxxxxxxxxx>
> > > > Tested-by: Sebastian Reichel <sre@xxxxxxxxxx>
> > > > Signed-off-by: Tony Lindgren <tony@xxxxxxxxxxx>
> > > > ---
> > > > drivers/mfd/motorola-cpcap.c | 3 +++
> > > > 1 file changed, 3 insertions(+)
> > >
> > > Applied, thanks.
> >
> > Sorry this one depends on patch 1/4 for .handle_reread. So this
> > one should be reverted or dropped. That will cause trivial merge
> > conflicts with patches 2 and 4.
> >
> > Please let me know if you want me to resend just patches 2 and 4
> > as patches 1 and 2 need more work.
>
> Yes, I found that out (and replied to the regmap patch).
>
> I'll revert them all for now.
OK thanks.
> Awaiting a subsequent revision.
Sent as "[PATCHv3 0/3] CPCAP PMIC IRQ fix and related changes"
with regmap changes dropped as I figured out what the real issue
with lost interrupts was :)
Regards,
Tony