Re: [PATCH] mm/zswap: fix potential deadlock in zswap_frontswap_store()

From: Andrey Ryabinin
Date: Mon Apr 03 2017 - 09:45:36 EST


On 04/03/2017 04:28 PM, Vlastimil Babka wrote:

>>
>>
>> Seems it was broken by
>>
>> a8161d1ed6098506303c65b3701dedba876df42a
>> Author: Vlastimil Babka <vbabka@xxxxxxx>
>> Date: Thu Jul 28 15:49:19 2016 -0700
>>
>> mm, page_alloc: restructure direct compaction handling in slowpath
>
> Yeah, looks like previously the code subtly relied on compaction being
> called only after the PF_MEMALLOC -> goto nopage check and I didn't
> notice it. Tell me if I should add a check or you plan to send a patch.
> Thanks!

I would be glad if you could take care of this.