Re: [PATCH v2] i2c/muxes/i2c-mux-ltc4306: LTC4306 and LTC4305 I2C multiplexer/switch

From: Michael Hennerich
Date: Mon Apr 03 2017 - 09:35:15 EST


On 03.04.2017 14:03, Peter Rosin wrote:
On 2017-03-31 17:29, Peter Rosin wrote:
Hi!

Sorry for my incremental reviewing...


Another incremental...

On 2017-03-29 12:15, michael.hennerich@xxxxxxxxxx wrote:
+
+ /* Now create an adapter for each channel */
+ for (num = 0; num < data->chip->nchans; num++) {
+ ret = i2c_mux_add_adapter(muxc, 0, num, 0);
+ if (ret) {
+ dev_err(&client->dev,
+ "failed to register multiplexed adapter %d\n",
+ num);

Just a heads up, I submitted a series to remove a bunch of dev_err calls
when i2c_mux_add_adapter fails. See https://lkml.org/lkml/2017/4/3/115

You can remove this one as well.

And please use a subject of the form:
i2c: mux: ltc4306: <message>

Cheers,
peda

ok - no problem.
I sent out a new patch. Per Rob's request, I split out the dt-bindings into a separate patch.

--
Greetings,
Michael

--
Analog Devices GmbH Otl-Aicher Strasse 60-64 80807 München
Sitz der Gesellschaft München, Registergericht München HRB 40368,
Geschäftsführer: Peter Kolberg, Ali Raza Husain, Eileen Wynne