Re: [PATCH] i2c: designware: Get selected speed mode sda-hold-time via ACPI

From: Jarkko Nikula
Date: Fri Mar 31 2017 - 08:14:34 EST


On 03/28/2017 12:13 PM, Andy Shevchenko wrote:
On Tue, 2017-03-28 at 16:48 +0800, Tan Chin Yew wrote:
Sda-hold-time is an important parameter for tuning i2c to meet the
electrical specification especially for high speed. I2C with incorrect
sda-hold-time may cause lost arbitration error. Instead of loading all
speed mode settings, only selected speed mode settings are loaded.

Signed-off-by: Tan Chin Yew <chin.yew.tan@xxxxxxxxx>


Looks good to me:

Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>

Acked-by: Jarkko Nikula <jarkko.nikula@xxxxxxxxxxxxxxx>