Re: [PATCH] macintosh: Do not arbitrarily limit architecture for macintosh drivers.

From: Arnd Bergmann
Date: Wed Mar 29 2017 - 17:33:13 EST


On Wed, Mar 29, 2017 at 3:33 PM, Michal Suchanek <msuchanek@xxxxxxx> wrote:
> The mac mouse emulation is neat solution for notebooks with suboptimal
> touchpads. For historical reason this is available on x86 but not arm or
> mips so remove the limitation.
>
> The other more specific drivers depend on various platform drivers
> anyway so users will not select those by accident.
>
> Signed-off-by: Michal Suchanek <msuchanek@xxxxxxx>
> ---
> drivers/macintosh/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/macintosh/Kconfig b/drivers/macintosh/Kconfig
> index 97a420c11eed..c23c040bc668 100644
> --- a/drivers/macintosh/Kconfig
> +++ b/drivers/macintosh/Kconfig
> @@ -1,7 +1,6 @@
>
> menuconfig MACINTOSH_DRIVERS
> bool "Macintosh device drivers"
> - depends on PPC || MAC || X86
> default y if (PPC_PMAC || MAC)
> ---help---
> Say Y here to get to see options for devices used with Macintosh
> --

Why not move the mac_hid module to drivers/input instead so
it no longer depends on MACINTOSH_DRIVERS?

For the other mac drivers, it may be helpful to to add '|| COMPILE_TEST'
to the dependency line here to allow building them on ARM (after
you have verified that we can in fact build them all without warnings),
but that would be unrelated.

Arnd