Re: syscall_get_error() && TS_ checks

From: Linus Torvalds
Date: Wed Mar 29 2017 - 14:57:02 EST


On Wed, Mar 29, 2017 at 11:50 AM, Oleg Nesterov <oleg@xxxxxxxxxx> wrote:
>
> Again, afaics we only need these compat checks because regs->ax could be
> changed by 32-bit debugger without sign-extension.

You don't explain how you were planning on *fixing* that code. You
know why it exists, but then you just say "let's remove it", without
any explanation of what you'd replace it with.

If your suggestion is just that "let's remove it, breaking the known
reason it's there", I really really don't see the upside.

It may be hacky, but it *works*. You seem to be advocating replacing
it with something simpler - "cleaner, but broken".

I really don't see the point of "cleaner, but broken".

The fact is, reality is not "clean". But reality trumps :I wish" and
"make-believe" every single time.

Linus