Re: [PATCH] VSOCK: remove unnecessary ternary operator on return value

From: David Miller
Date: Wed Mar 29 2017 - 00:50:10 EST


From: Colin King <colin.king@xxxxxxxxxxxxx>
Date: Tue, 28 Mar 2017 16:54:24 +0100

> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>
> Rather than assign the positive errno values to ret and then
> checking if it is positive and flip the sign, just set ret to
> be the -ve errno value.
>
> Detected by CoverityScan, CID#986649 ("Logically Dead Code")
>
> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>

Just return the error directly instead of having this variable.

Thanks.