Re: [PATCHv2 6/8] x86/dump_pagetables: Add support 5-level paging

From: Kirill A. Shutemov
Date: Tue Mar 28 2017 - 17:15:39 EST


On Tue, Mar 28, 2017 at 08:55:22PM +0200, Borislav Petkov wrote:
> On Tue, Mar 28, 2017 at 01:48:06PM +0300, Kirill A. Shutemov wrote:
> > Simple extension to support one more page table level.
> >
> > Signed-off-by: Kirill A. Shutemov <kirill.shutemov@xxxxxxxxxxxxxxx>
> > ---
> > arch/x86/mm/dump_pagetables.c | 59 +++++++++++++++++++++++++++++++++----------
> > 1 file changed, 45 insertions(+), 14 deletions(-)
>
> Hmm, so without this I get the splat below.

On current tip/master?

> Can we do something about this bisection breakage? I mean, this is the
> second explosion caused by 5level paging I trigger. Maybe we should
> merge the whole thing into a single big patch when everything is applied
> and tested, more or less, so that bisection is fine.
>
> Or someone might have a better idea...

I'm not sure that collapsing history in one commit to fix bisectability is
any better than having broken bisectability.

I'll try to look more into this issue tomorrow.

Sorry for this.

--
Kirill A. Shutemov