Re: [PATCH v1 1/2] auxdisplay: Move panel.c to drivers/auxdisplay folder

From: Arnd Bergmann
Date: Mon Mar 27 2017 - 10:24:48 EST


On Fri, Mar 24, 2017 at 4:19 PM, Geert Uytterhoeven
<geert@xxxxxxxxxxxxxx> wrote:
> Hi Andy,
>
> On Fri, Mar 24, 2017 at 3:29 PM, Andy Shevchenko
> <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
>> On Fri, 2017-03-24 at 15:19 +0100, Geert Uytterhoeven wrote:
>>> On Fri, Mar 24, 2017 at 3:06 PM, Andy Shevchenko
>>> <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
>>> > It looks like panel.c belongs to auxdisplay subsystem.
>>> >
>>> > Move it to drivers/auxdisplay folder.
>>> > No functional changes intended.
>>>
>>> I didn't move it to drivers/auxdisplay/ because it not only provides
>>> auxdisplay functionality, but also keypad functionality.
>>
>> Yes, I have noticed this. But keypad functionality is optional while
>> panel is main one. I think you would agree on this.
>
> I don't care that much, though. Willy?

I think moving all of it to drivers/auxdisplay as it is today, and doing
any further cleanup on the driver over there is a good idea.

On a related note, how about moving arm-charlcd there as well,
and finding a new place for the various ALS drivers?

Arnd