Re: [PATCH v5 5/8] dt-bindings: input: touchscreen: Add max11801-ts binding

From: Shawn Guo
Date: Wed Mar 15 2017 - 22:54:43 EST


On Tue, Mar 14, 2017 at 03:18:14PM +0530, Jagan Teki wrote:
> From: Jagan Teki <jagan@xxxxxxxxxxxxxxxxxxxx>
>
> Add missing documentation of max11801-ts dt-binding details.
>
> Cc: Mark Rutland <mark.rutland@xxxxxxx>
> Cc: Rob Herring <robh+dt@xxxxxxxxxx>
> Cc: Shawn Guo <shawnguo@xxxxxxxxxx>
> Cc: Michael Trimarchi <michael@xxxxxxxxxxxxxxxxxxxx>
> Signed-off-by: Jagan Teki <jagan@xxxxxxxxxxxxxxxxxxxx>
> ---
> Changes for v5:
> - Newly added patch
>
> .../bindings/input/touchscreen/max11801-ts.txt | 18 ++++++++++++++++++
> 1 file changed, 18 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/input/touchscreen/max11801-ts.txt
>
> diff --git a/Documentation/devicetree/bindings/input/touchscreen/max11801-ts.txt b/Documentation/devicetree/bindings/input/touchscreen/max11801-ts.txt
> new file mode 100644
> index 0000000..b6ac452
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/input/touchscreen/max11801-ts.txt
> @@ -0,0 +1,18 @@
> +* MAXI MAX11801 Resistive touch screen controller with i2c interface
> +
> +Required properties:
> +- compatible: must be "max11801"
> +- reg: i2c slave address
> +- interrupt-parent: the phandle for the interrupt controller
> +- interrupts: touch controller interrupt
> +
> +Example:
> +
> +&i2c1 {
> + ts: max11801@48 {

Node name should be generic while label can be specific. That said, the
following form might be better choice.

max11801: touchscreen@48 {

Shawn

> + compatible = "max11801";
> + reg = <0x48>;
> + interrupt-parent = <&gpio3>;
> + interrupts = <31 2>;
> + };
> +};
> --
> 1.9.1
>