Re: [PATCH v2] mfd: intel_soc_pmic: Fix a mess with compilation units

[Lee Jones]

On Tue, 14 Mar 2017, Andy Shevchenko wrote:

> On Tue, 2017-03-14 at 15:02 +0000, Lee Jones wrote:
> > On Mon, 13 Mar 2017, Andy Shevchenko wrote:
> > 
> > > Crystal Cove and Whiskey Cove are two different PMICs which are
> > > installed on Intel Atom SoC based platforms.
> > > 
> > > Moreover there are two independent drivers that by some reason are
> > > supposed (*) to get into one kernel module.
> > > 
> > > Fix the mess by clarifying Kconfig option for Crystal Cove and split
> > > Whiskey Cove out of it.
> > > 
> > > (*) It looks like the configuration was never ever tested. The line
> > > in
> > > ÂÂÂÂMakefile is actually wrong.
> Â
> > > Âconfig INTEL_SOC_PMIC
> > > -	bool "Support for Intel Atom SoC PMIC"
> > > +	bool "Support for Crystal Cove PMIC"
> > > Â	depends on GPIOLIB
> > > Â	depends on I2C=y
> > > Â	select MFD_CORE
> > > Â	select REGMAP_I2C
> > > Â	select REGMAP_IRQ
> > > Â	help
> > > -	ÂÂSelect this option to enable support for the PMIC device
> > > +	ÂÂSelect this option to enable support for Crystal Cove
> > > PMIC
> > > Â	ÂÂon some Intel SoC systems. The PMIC provides ADC, GPIO,
> > > Â	ÂÂthermal, charger and related power management functions
> > > Â	ÂÂon these systems.
> > > Â
> > > +config INTEL_SOC_PMIC_BXTWC
> > > +	tristate
> > > +	select MFD_CORE
> > > +	select REGMAP_IRQ
> > 
> > I think you need to make mention that this is Whiskey Cove?
> 
> It's selectable option, so I don't know if it's a good idea to make it
> visible to the user. Or do you mean fill the help section only?

I think you just answered your own question. :)

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog