Re: [PATCH v2 4/8] ARM: dts: s3c64xx: Enable watchdog on all S3C64xx boards

From: Krzysztof Kozlowski
Date: Tue Mar 14 2017 - 09:04:43 EST


On Tue, Mar 14, 2017 at 2:58 PM, Bartlomiej Zolnierkiewicz
<b.zolnierkie@xxxxxxxxxxx> wrote:
>
> Hi,
>
> On Saturday, March 11, 2017 07:25:23 PM Krzysztof Kozlowski wrote:
>> Watchdog module does not have external dependencies so it can be safely
>> enabled in s3c64xx.dtsi thus making it available for all S3C64xx-based
>> boards.
>>
>> Signed-off-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
>
> Please first fix the driver w.r.t. infinite interrupt in soft mode
> issue and only then enable it on more hardware. IOW this patch
> should be placed after patch #7 in the series.

The soft-interrupt mode is not the default one so this should not
cause any issues by default but I got your point. Makes sense. The
pity is the timing. There wasn't much interest in the patchset (no
comments since 24 of Feb) so I merged it yesterday evening. Does it
brake any platform/board?

Best regards,
Krzysztof