Re: [PATCH 1/4] ARM: OMAP2+: omap_hwmod: provide space for more hwmod flags

From: Roger Quadros
Date: Tue Mar 14 2017 - 06:49:46 EST


On 13/03/17 15:35, Sekhar Nori wrote:
> On Monday 13 March 2017 05:23 PM, Roger Quadros wrote:
>> From: Sekhar Nori <nsekhar@xxxxxx>
>>
>> 'flags' member of omap_hwmod structure is fast running
>> out of space with 16 different flags already defined.
>>
>> Make flags a 32-bit entity so as to allow for more flags.
>>
>> This results is a ~2.3K data section size increase with
>> TI config fragments.
>
> This line needs to be changed to refer to omap2plus_defconfig.

OK.

>
>>
>> before:
>> text data bss dec hex filename
>> 8886648 610452 261876 9758976 94e900 vmlinux
>>
>> after:
>> text data bss dec hex filename
>> 8886584 612820 261876 9761280 94f200 vmlinux
>
> I guess this data is probably stale as well. Here is the before and
> after numbers using omap2plus_defconfig on v4.11-rc2
>
> before:
> text data bss dec hex filename
> 8186930 3082444 8252992 19522366 129e33e vmlinux
>
> after:
> text data bss dec hex filename
> 8186922 3084812 8252992 19524726 129ec76 vmlinux
>
> The size increase remains at ~2.3K in data section.
>

Thanks for the new figures. I'll resend the patch with updated data.

--
cheers,
-roger