Re: [PATCH] ks7010: adding parenthesis to macro argument

From: Dan Carpenter
Date: Tue Mar 14 2017 - 06:42:27 EST


On Tue, Mar 14, 2017 at 03:01:50AM -0700, Pushkar Jambhlekar wrote:
> Hi Dan,
>
> I am trying to fix warnings by "checkpatch.pl". Even though it is not
> super exciting, no harm to follow correct way.
>

The harm is that it takes something that's already terrible and makes it
even more unreadable.

regards,
dan carpenter