Re: [PATCH net-next 08/12] net: bcmgenet: correct return value of __bcmgenet_tx_reclaim

From: Florian Fainelli
Date: Mon Mar 13 2017 - 20:57:56 EST


On 03/13/2017 05:41 PM, Doug Berger wrote:
> The reclaim function should return the number of buffer descriptors
> reclaimed, not just the number corresponding to skb packets.
>
> Also, remove the unnecessary computation when updating the consumer
> index.
>
> While this is not a functional problem it could degrade performance
> of napi in a fragmented transmit stream.
>
> Signed-off-by: Doug Berger <opendmb@xxxxxxxxx>

Reviewed-by: Florian Fainelli <f.fainelli@xxxxxxxxx>
--
Florian