Re: [PATCH] platform/x86: intel-hid: do not set parents of input devices explicitly

From: Alex Hung
Date: Mon Mar 13 2017 - 06:37:55 EST


On 2017-03-09 05:36 PM, MichaÅ KÄpieÅ wrote:
devm_input_allocate_device() already causes the supplied struct device
to be set as the parent of the input device, so doing it again is
redundant.

Signed-off-by: MichaÅ KÄpieÅ <kernel@xxxxxxxxxx>
---
This patch needs my recent intel-hid cleanup series to apply cleanly.
In other words, it should apply on top of testing, but not for-next.

drivers/platform/x86/intel-hid.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/platform/x86/intel-hid.c b/drivers/platform/x86/intel-hid.c
index 5eab31659cba..b40059aba856 100644
--- a/drivers/platform/x86/intel-hid.c
+++ b/drivers/platform/x86/intel-hid.c
@@ -152,7 +152,6 @@ static int intel_hid_input_setup(struct platform_device *device)
if (ret)
return ret;

- priv->input_dev->dev.parent = &device->dev;
priv->input_dev->name = "Intel HID events";
priv->input_dev->id.bustype = BUS_HOST;

@@ -173,7 +172,6 @@ static int intel_button_array_input_setup(struct platform_device *device)
if (ret)
return ret;

- priv->array->dev.parent = &device->dev;
priv->array->name = "Intel HID 5 button array";
priv->array->id.bustype = BUS_HOST;




The patch, on top of previous patches, is tested on Latitude 7480

Reviewed-and-tested-by: Alex Hung <alex.hung@xxxxxxxxxxxxx>