Re: [PATCH 01/10] ALSA SoC MAX98927 driver - Initial release

From: Rob Herring
Date: Sun Mar 12 2017 - 10:11:15 EST


On Fri, Mar 03, 2017 at 11:52:39PM +0900, Ryan Lee wrote:
> From: Ryan Lee <RyanS.Lee@xxxxxxxxxxxxxxxxxxx>
>
> Signed-off-by: Ryan Lee <ryans.lee@xxxxxxxxxxxxxxxxxxx>
> ---
>
> Initial release of ALSA SoC MAX98927 driver.
>
> .../devicetree/bindings/sound/max98927.txt | 32 +

In addition to what Mark said, please split bindings to a separate
patch.

> sound/soc/codecs/Kconfig | 5 +
> sound/soc/codecs/Makefile | 2 +
> sound/soc/codecs/max98927.c | 954 +++++++++++++++
> sound/soc/codecs/max98927.h | 1253 ++++++++++++++++++++
> 5 files changed, 2246 insertions(+)
> create mode 100755 Documentation/devicetree/bindings/sound/max98927.txt
> mode change 100644 => 100755 sound/soc/codecs/Kconfig
> mode change 100644 => 100755 sound/soc/codecs/Makefile
> create mode 100755 sound/soc/codecs/max98927.c
> create mode 100755 sound/soc/codecs/max98927.h

These files should not be executable.

Rob