Re: [PATCH v1] staging: media: Remove unused function atomisp_set_stop_timeout()

From: Greg KH
Date: Sun Mar 12 2017 - 09:57:23 EST


On Fri, Mar 10, 2017 at 07:05:05PM +0530, simran singhal wrote:
> The function atomisp_set_stop_timeout on being called, simply returns
> back. The function hasn't been mentioned in the TODO and doesn't have
> FIXME code around. Hence, atomisp_set_stop_timeout and its calls have been
> removed.
>
> This was done using Coccinelle.
>
> @@
> identifier f;
> @@
>
> void f(...) {
>
> -return;
>
> }
>
> Signed-off-by: simran singhal <singhalsimran0@xxxxxxxxx>
> ---
> v1:
> -Change Subject to include name of function
> -change commit message to include the coccinelle script

You should also cc: the developers doing all of the current work on this
driver, Alan Cox, to get their comment if this really is something that
can be removed or not.

thanks,

greg k-h