Re: [PATCH v1 01/10] staging: iio: ad7192: Remove exceptional & on function name

From: Jonathan Cameron
Date: Sat Mar 11 2017 - 13:36:45 EST


On 11/03/17 14:26, simran singhal wrote:
> Remove & from function pointers to conform to the style found elsewhere
> in the file. Done using the following semantic patch
>
> // <smpl>
> @r@
> identifier f;
> @@
>
> f(...) { ... }
> @@
> identifier r.f;
> @@
>
> - &f
> + f
> // </smpl>
>
> Signed-off-by: simran singhal <singhalsimran0@xxxxxxxxx>
Applied to the togreg branch of iio.git and pushed out as
testing for the autobuilders to play with it.

Thanks,

Jonathan
> ---
> drivers/staging/iio/adc/ad7192.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/staging/iio/adc/ad7192.c b/drivers/staging/iio/adc/ad7192.c
> index 4fc8588..d11c6de 100644
> --- a/drivers/staging/iio/adc/ad7192.c
> +++ b/drivers/staging/iio/adc/ad7192.c
> @@ -564,18 +564,18 @@ static int ad7192_write_raw_get_fmt(struct iio_dev *indio_dev,
> }
>
> static const struct iio_info ad7192_info = {
> - .read_raw = &ad7192_read_raw,
> - .write_raw = &ad7192_write_raw,
> - .write_raw_get_fmt = &ad7192_write_raw_get_fmt,
> + .read_raw = ad7192_read_raw,
> + .write_raw = ad7192_write_raw,
> + .write_raw_get_fmt = ad7192_write_raw_get_fmt,
> .attrs = &ad7192_attribute_group,
> .validate_trigger = ad_sd_validate_trigger,
> .driver_module = THIS_MODULE,
> };
>
> static const struct iio_info ad7195_info = {
> - .read_raw = &ad7192_read_raw,
> - .write_raw = &ad7192_write_raw,
> - .write_raw_get_fmt = &ad7192_write_raw_get_fmt,
> + .read_raw = ad7192_read_raw,
> + .write_raw = ad7192_write_raw,
> + .write_raw_get_fmt = ad7192_write_raw_get_fmt,
> .attrs = &ad7195_attribute_group,
> .validate_trigger = ad_sd_validate_trigger,
> .driver_module = THIS_MODULE,
>