Re: [PATCH] powerpc: sysdev: cpm1: Optimise gpio bit calculation

From: Christophe LEROY
Date: Fri Mar 10 2017 - 09:05:09 EST




Le 10/03/2017 à 14:06, Segher Boessenkool a écrit :
On Fri, Mar 10, 2017 at 11:54:19AM +0100, Christophe LEROY wrote:
gpio_get() and gpio_set() are used extensively by some GPIO based
drivers like SPI, NAND, so it may be worth it as it doesn't impair
readability (if anyone prefers, we could write (1 << 31) >> i instead
of 0x80000000 >> i )

1 << 31 is undefined behaviour, of course.


Shall it be 1U << 31 ?

Christophe