Re: [PATCH] cpufreq: intel_pstate: Drop redundant wrapper function

[Viresh Kumar]

On Thu, Mar 9, 2017 at 9:00 PM, Rafael J. Wysocki <rjw@xxxxxxxxxxxxx> wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>
>
> intel_pstate_hwp_set_policy() is a wrapper around
> intel_pstate_hwp_set(), but the only value it adds is to check
> hwp_active before calling the latter and one of its two callers
> has already checked hwp_active before that happens, so in that
> code path the additional check is redundant and using the wrapper
> is rather pointless.
>
> For this reason, drop intel_pstate_hwp_set_policy() and make its
> callers invoke intel_pstate_hwp_set() directly (after checking
> hwp_active).
>
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>
> ---
>  drivers/cpufreq/intel_pstate.c |   18 ++++--------------
>  1 file changed, 4 insertions(+), 14 deletions(-)

Acked-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx>