Re: [Outreachy kernel] [PATCH 5/6] staging: speakup: Alignment should match open parenthesis

From: Julia Lawall
Date: Thu Mar 09 2017 - 16:36:32 EST




On Fri, 10 Mar 2017, Arushi Singhal wrote:

> Fix checkpatch issues: "CHECK: Alignment should match open parenthesis".
>
> Signed-off-by: Arushi Singhal <arushisinghal19971997@xxxxxxxxx>
> ---
> if (synth_request_region(speakup_info.port_tts - 1,
> - SYNTH_IO_EXTENT)) {
> + SYNTH_IO_EXTENT)) {
> pr_warn("sorry, port already reserved\n");
> return -EBUSY;
> }
> @@ -270,7 +270,7 @@ static int synth_probe(struct spk_synth *synth)
> } else {
> for (i = 0; synth_portlist[i]; i++) {
> if (synth_request_region(synth_portlist[i],
> - SYNTH_IO_EXTENT)) {
> + SYNTH_IO_EXTENT)) {

These are not correct. SYNTH_IO_EXTENT should be lines up with the right
side of the ( of the argument list of which it is an element. So the
original code is either correct or close to correct.

julia