Re: [PATCH 1/2] staging: media: Clean up tests if NULL returned on failure

From: Greg KH
Date: Thu Mar 09 2017 - 12:11:28 EST


On Sat, Mar 04, 2017 at 12:25:18AM +0530, simran singhal wrote:
> Some functions like kmalloc/kzalloc return NULL on failure.
> When NULL represents failure, !x is commonly used.
>
> This was done using Coccinelle:
> @@
> expression *e;
> identifier l1;
> @@
>
> e = \(kmalloc\|kzalloc\|kcalloc\|devm_kzalloc\)(...);
> ...
> - e == NULL
> + !e
>
> Signed-off-by: simran singhal <singhalsimran0@xxxxxxxxx>
> ---
> drivers/staging/media/atomisp/pci/atomisp2/atomisp_fops.c | 2 +-
> drivers/staging/media/davinci_vpfe/vpfe_mc_capture.c | 4 ++--
> drivers/staging/media/lirc/lirc_zilog.c | 6 +++---
> 3 files changed, 6 insertions(+), 6 deletions(-)

Please break this up into one patch per driver.

thanks,

greg k-h