Re: [PATCH v2 08/22] PCI: dwc: designware: Add EP mode support

From: Joao Pinto
Date: Thu Mar 09 2017 - 06:55:40 EST


Hi Christoph,

Às 7:14 PM de 3/8/2017, Christoph Hellwig escreveu:
> On Wed, Mar 08, 2017 at 03:32:03PM +0000, Joao Pinto wrote:
>> #define PCIE_GET_ATU_INB_UNR_REG_ADDR(region, register) \
>> ((0x3 << 20) | (region << 9) | \
>> (0x1 << 8)
>
> Can you turn this and any similar macro into inline functions?
>

Use an inline functions instead of macro is fine by me. In the initial patch I
implemented as a macro since it only does simple bit shifts and nothing else and
seemed simpler as a macro.

Thanks,
Joao