RE: [PATCH 22/29] drivers, scsi: convert iscsi_task.refcount from atomic_t to refcount_t

From: Reshetova, Elena
Date: Thu Mar 09 2017 - 04:26:22 EST



> On 03/09/2017 08:18 AM, Reshetova, Elena wrote:
> >> On Mon, Mar 06, 2017 at 04:21:09PM +0200, Elena Reshetova wrote:
> >>> refcount_t type and corresponding API should be
> >>> used instead of atomic_t when the variable is used as
> >>> a reference counter. This allows to avoid accidental
> >>> refcounter overflows that might lead to use-after-free
> >>> situations.
> >>>
> >>> Signed-off-by: Elena Reshetova <elena.reshetova@xxxxxxxxx>
> >>> Signed-off-by: Hans Liljestrand <ishkamiel@xxxxxxxxx>
> >>> Signed-off-by: Kees Cook <keescook@xxxxxxxxxxxx>
> >>> Signed-off-by: David Windsor <dwindsor@xxxxxxxxx>
> >>
> >> This looks OK to me.
> >>
> >> Acked-by: Chris Leech <cleech@xxxxxxxxxx>
> >
> > Thank you for review! Do you have a tree that can take this change?
>
> Hi Elena,
>
> iscsi like fcoe should go via the SCSI tree.

Thanks Johannes! Should I resend with "Acked-by" added in order for it to be picked up?

Best Regards,
Elena.


>
> Byte,
> Johannes
>
> --
> Johannes Thumshirn Storage
> jthumshirn@xxxxxxx +49 911 74053 689
> SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
> GF: Felix Imendörffer, Jane Smithard, Graham Norton
> HRB 21284 (AG Nürnberg)
> Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850