Re: [PATCH for-4.11] ASoC: don't dereference NULL pcm_{new,free}

From: Kuninori Morimoto
Date: Wed Mar 08 2017 - 20:00:22 EST



Hi Brian

> > It is a littlle bit strange for me.
>
> Yes, and honestly I'm a little confused by the inheritance in this
> framework.

Yes, I agree :)
This is 1st prepare for future ALSA SoC framework cleanup
It is Lars-Peter's idea

> I have a feeling you're checking the wrong thing below for this case.

If so, we should fix this "wrong thing" ?

> All I know is that I'm definitely hitting a NULL
> platform->driver->pcm_new callback, and that either reverting your patch
> or applying the patch I just sent fixes it.

I want to know why this happen.
Can you show me which driver is calling snd_soc_add_platform() in your case ?