Re: [PATCH] mm: drop "wait" parameter from write_one_page

[John Hubbard]

On 03/08/2017 03:30 AM, Jeff Layton wrote:
[...]
> Thanks for having a look. That blurb in the changelog refers to the
> kerneldoc comment over write_one_page below...
>
> >   No existing caller uses this on normal files, so
> > > none of them need it.
> > >
> > > Signed-off-by: Jeff Layton <jlayton@xxxxxxxxxx>
[...]
> > >  /**
> > > - * write_one_page - write out a single page and optionally wait on I/O
> > > + * write_one_page - write out a single page and wait on I/O
> > >   * @page: the page to write
> > > - * @wait: if true, wait on writeout
> > >   *
> > >   * The page must be locked by the caller and will be unlocked upon return.
> > >   *
> > > - * write_one_page() returns a negative error code if I/O failed.
> > > + * write_one_page() returns a negative error code if I/O failed. Note that
> > > + * the address_space is not marked for error. The caller must do this if
> > > + * needed.
>
> ...specifically the single sentence in the comment above.
>
> As I said, none of the existing callers need to set an error in the
> mapping when this fails, so I just added this to make it clear for any
> new callers in the future.

Yes, somehow, even in this tiny patchset, I missed those two new comment lines. 
arghh. :)

Well, everything looks great, then.

thanks,
John Hubbard
NVIDIA