Re: [Xen-devel] [PATCH 29/29] drivers, xen: convert grant_map.users from atomic_t to refcount_t

From: Boris Ostrovsky
Date: Wed Mar 08 2017 - 12:45:56 EST


On 03/08/2017 08:49 AM, Reshetova, Elena wrote:
>> On 03/06/2017 09:21 AM, Elena Reshetova wrote:
>>> refcount_t type and corresponding API should be
>>> used instead of atomic_t when the variable is used as
>>> a reference counter. This allows to avoid accidental
>>> refcounter overflows that might lead to use-after-free
>>> situations.
>>>
>>> Signed-off-by: Elena Reshetova <elena.reshetova@xxxxxxxxx>
>>> Signed-off-by: Hans Liljestrand <ishkamiel@xxxxxxxxx>
>>> Signed-off-by: Kees Cook <keescook@xxxxxxxxxxxx>
>>> Signed-off-by: David Windsor <dwindsor@xxxxxxxxx>
>>> ---
>>> drivers/xen/gntdev.c | 11 ++++++-----
>>> 1 file changed, 6 insertions(+), 5 deletions(-)
>> Reviewed-by: Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>
> Is there a tree that can take this change? Turns out it is better to propagate changes via separate trees and only leftovers can be taken via Greg's tree.
>

Sure, we can take it via Xen tree for rc3.

-boris