Re: [PATCH 01/23] perf report: Hide tip message when -q option is given

From: Arnaldo Carvalho de Melo
Date: Tue Mar 07 2017 - 11:42:29 EST


Em Wed, Mar 08, 2017 at 12:08:29AM +0900, Namhyung Kim escreveu:
> The tip message at the end was printed regardless of the -q option.
> Originally, the message suggested only '-s comm,dso' option for higher
> level view when no sort option and parent option were given. Now it
> shows random help message regardless of the options so the condition can
> be simplified to honor the -q option.
>

Applied, with this:

Before:

$ perf report --stdio -q
42.77% ls ls [.] _init
13.21% ls ld-2.24.so [.] match_symbol
12.55% ls libc-2.24.so [.] __strcoll_l
11.94% ls libc-2.24.so [.] _init


#
# (Tip: Show current config key-value pairs: perf config --list)
#
$

After:

$ perf report --stdio -q
42.77% ls ls [.] _init
13.21% ls ld-2.24.so [.] match_symbol
12.55% ls libc-2.24.so [.] __strcoll_l
11.94% ls libc-2.24.so [.] _init


$

We still have those two extra lines tho, food for another patch...