Re: [PATCH v2] Input: sparse-keymap - use a managed allocation for keymap copy

From: Andy Shevchenko
Date: Mon Mar 06 2017 - 02:42:10 EST


On Mon, Mar 6, 2017 at 9:09 AM, MichaÅ KÄpieÅ <kernel@xxxxxxxxxx> wrote:
>> On Thu, Mar 2, 2017 at 2:02 PM, MichaÅ KÄpieÅ <kernel@xxxxxxxxxx> wrote:

>> > + * Since sparse_keymap_setup() now uses a managed allocation for the
>> > + * keymap copy, use of this function is deprecated.
>>
>> So...
>>
>> > */
>> > void sparse_keymap_free(struct input_dev *dev)
>>
>> ... add __deprecated then?
>
> Sure, I can do that if Dmitry recognizes this patch as otherwise sane.
> I have never used that attribute before, so thanks for the tip.

It will provoke a warning when compiling the code.
It makes sense if anyone is going to fix the current users and leave
old API for one cycle.

So, the question is what we are going to do with an old API.

--
With Best Regards,
Andy Shevchenko