Re: [PATCH v5 3/5] staging: lustre: lustre: Remove unnecessary cast on void pointer

From: James Simmons
Date: Sat Mar 04 2017 - 19:51:49 EST



> The following Coccinelle script was used to detect this:
> @r@
> expression x;
> void* e;
> type T;
> identifier f;
> @@
> (
> *((T *)e)
> |
> ((T *)x)[...]
> |
> ((T*)x)->f
> |
> - (T*)
> e
> )
>
> Signed-off-by: simran singhal <singhalsimran0@xxxxxxxxx>

Reviewed-by: James Simmons <jsimmons@xxxxxxxxxxxxx>

> ---
>
> v5:
> -Fixed compilation warnings.
>
> drivers/staging/lustre/lustre/llite/range_lock.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/lustre/lustre/llite/range_lock.c b/drivers/staging/lustre/lustre/llite/range_lock.c
> index 14148a0..161391b 100644
> --- a/drivers/staging/lustre/lustre/llite/range_lock.c
> +++ b/drivers/staging/lustre/lustre/llite/range_lock.c
> @@ -174,7 +174,7 @@ void range_unlock(struct range_lock_tree *tree, struct range_lock *lock)
> */
> static enum interval_iter range_lock_cb(struct interval_node *node, void *arg)
> {
> - struct range_lock *lock = (struct range_lock *)arg;
> + struct range_lock *lock = arg;
> struct range_lock *overlap = node2rangelock(node);
>
> lock->rl_blocking_ranges += overlap->rl_lock_count + 1;
> --
> 2.7.4
>
> _______________________________________________
> devel mailing list
> devel@xxxxxxxxxxxxxxxxxxxxxx
> http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
>