Re: [RFC PATCH v2 19/32] crypto: ccp: Introduce the AMD Secure Processor device

[Brijesh Singh]

Hi Mark,

On 03/02/2017 11:39 AM, Mark Rutland wrote:
> On Thu, Mar 02, 2017 at 10:16:15AM -0500, Brijesh Singh wrote:
> > The CCP device is part of the AMD Secure Processor. In order to expand the
> > usage of the AMD Secure Processor, create a framework that allows functional
> > components of the AMD Secure Processor to be initialized and handled
> > appropriately.
> >
> > Signed-off-by: Brijesh Singh <brijesh.singh@xxxxxxx>
> > Signed-off-by: Tom Lendacky <thomas.lendacky@xxxxxxx>
> > ---
> >  drivers/crypto/Kconfig           |   10 +
> >  drivers/crypto/ccp/Kconfig       |   43 +++--
> >  drivers/crypto/ccp/Makefile      |    8 -
> >  drivers/crypto/ccp/ccp-dev-v3.c  |   86 +++++-----
> >  drivers/crypto/ccp/ccp-dev-v5.c  |   73 ++++-----
> >  drivers/crypto/ccp/ccp-dev.c     |  137 +++++++++-------
> >  drivers/crypto/ccp/ccp-dev.h     |   35 ----
> >  drivers/crypto/ccp/sp-dev.c      |  308 ++++++++++++++++++++++++++++++++++++
> >  drivers/crypto/ccp/sp-dev.h      |  140 ++++++++++++++++
> >  drivers/crypto/ccp/sp-pci.c      |  324 ++++++++++++++++++++++++++++++++++++++
> >  drivers/crypto/ccp/sp-platform.c |  268 +++++++++++++++++++++++++++++++
> >  include/linux/ccp.h              |    3
> >  12 files changed, 1240 insertions(+), 195 deletions(-)
> >  create mode 100644 drivers/crypto/ccp/sp-dev.c
> >  create mode 100644 drivers/crypto/ccp/sp-dev.h
> >  create mode 100644 drivers/crypto/ccp/sp-pci.c
> >  create mode 100644 drivers/crypto/ccp/sp-platform.c
>
> > diff --git a/drivers/crypto/ccp/Makefile b/drivers/crypto/ccp/Makefile
> > index 346ceb8..8127e18 100644
> > --- a/drivers/crypto/ccp/Makefile
> > +++ b/drivers/crypto/ccp/Makefile
> > @@ -1,11 +1,11 @@
> > -obj-$(CONFIG_CRYPTO_DEV_CCP_DD) += ccp.o
> > -ccp-objs := ccp-dev.o \
> > +obj-$(CONFIG_CRYPTO_DEV_SP_DD) += ccp.o
> > +ccp-objs := sp-dev.o sp-platform.o
> > +ccp-$(CONFIG_PCI) += sp-pci.o
> > +ccp-$(CONFIG_CRYPTO_DEV_CCP) += ccp-dev.o \
> >  	    ccp-ops.o \
> >  	    ccp-dev-v3.o \
> >  	    ccp-dev-v5.o \
> > -	    ccp-platform.o \
> >  	    ccp-dmaengine.o
>
> It looks like ccp-platform.c has morphed into sp-platform.c (judging by
> the compatible string and general shape of the code), and the original
> ccp-platform.c is no longer built.
>
> Shouldn't ccp-platform.c be deleted by this patch?

Good catch. Both ccp-platform.c and ccp-pci.c should have been deleted 
by this patch. I missed deleting it, will fix in next rev.

~ Brijesh