Re: [PATCH] tpm: select CONFIG_CRYPTO

From: Jarkko Sakkinen
Date: Thu Mar 02 2017 - 04:19:13 EST


On Tue, Feb 28, 2017 at 10:24:45PM +0100, Peter Huewe wrote:
>
>
> Am 28. Februar 2017 22:12:55 MEZ schrieb Arnd Bergmann <arnd@xxxxxxxx>:
> >We get a newly introduced harmless warning when CONFIG_CRYPTO is
> >disabled:
> >
> >warning: (TCG_TPM && TRUSTED_KEYS && IMA) selects CRYPTO_HASH_INFO
> >which has unmet direct dependencies (CRYPTO)
> >
> >This adds another select to avoid the warning, consistent with other
> >users
> >of the crypto code.
> >
> >Fixes: c1f92b4b04ad ("tpm: enhance TPM 2.0 PCR extend to support
> >multiple banks")
> >Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
> Lgtm
>
> Reviewed-by: Peter Huewe <peterhuewe@xxxxxx>

Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@xxxxxxxxxxxxxxx>

/Jarkko

> >---
> > drivers/char/tpm/Kconfig | 1 +
> > 1 file changed, 1 insertion(+)
> >
> >diff --git a/drivers/char/tpm/Kconfig b/drivers/char/tpm/Kconfig
> >index af985cca413c..d520ac51c11c 100644
> >--- a/drivers/char/tpm/Kconfig
> >+++ b/drivers/char/tpm/Kconfig
> >@@ -6,6 +6,7 @@ menuconfig TCG_TPM
> > tristate "TPM Hardware Support"
> > depends on HAS_IOMEM
> > select SECURITYFS
> >+ select CRYPTO
> > select CRYPTO_HASH_INFO
> > ---help---
> > If you have a TPM security chip in your system, which
>
> --
> Sent from my mobile