Re: [PATCH 0/4] blk-mq: cleanup on all kinds of kobjects

From: Peter Zijlstra
Date: Tue Feb 28 2017 - 04:49:31 EST


On Wed, Feb 22, 2017 at 06:13:58PM +0800, Ming Lei wrote:
> This patchset cleans up on kojects of request_queue.mq_kobj,
> sw queue's kobject and hw queue's kobject.
>
> The 1st patch initialized kobject of request_queue and sw queue
> in blk_mq_init_allocated_queue(), so we can avoid to initialize
> these kobjects several times, and this patch fixes one kerne
> warning reported from Omar Sandoval.
>
> The 2nd patch makes lifetime consitent between mq request queue/sw
> queue and their kobjects.
>
> The 3rd patch makes lifetime consitent between hw queue and their
> kobjects.
>
> The last patch is a followup of 3rd patch.

These do indeed make the kobject warnings, and the resulting refcount
warning, go away.

Tested-by: Peter Zijlstra (Intel) <peterz@xxxxxxxxxxxxx>