Re: [PATCH 1/4] input:touchscreen:ad7879-spi.c: Fix regmap flag_masks

From: Dmitry Torokhov
Date: Thu Feb 23 2017 - 03:44:02 EST


On Wed, Feb 22, 2017 at 05:14:35PM +0100, michael.hennerich@xxxxxxxxxx wrote:
> From: Michael Hennerich <michael.hennerich@xxxxxxxxxx>
>
> Mask only applied to the top byte of the register
>
> Signed-off-by: Michael Hennerich <michael.hennerich@xxxxxxxxxx>

Thank you Michael, I folded it with the patch introducing regmaps.

> ---
> drivers/input/touchscreen/ad7879-spi.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/input/touchscreen/ad7879-spi.c b/drivers/input/touchscreen/ad7879-spi.c
> index f2c06b5..b995891 100644
> --- a/drivers/input/touchscreen/ad7879-spi.c
> +++ b/drivers/input/touchscreen/ad7879-spi.c
> @@ -19,8 +19,8 @@
>
> #define MAX_SPI_FREQ_HZ 5000000
>
> -#define AD7879_CMD_MAGIC 0xE000
> -#define AD7879_CMD_READ BIT(10)
> +#define AD7879_CMD_MAGIC 0xE0
> +#define AD7879_CMD_READ BIT(2)
>
> static const struct regmap_config ad7879_spi_regmap_config = {
> .reg_bits = 16,
> --
> 2.7.4
>

--
Dmitry